Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gvm-libs-22.15.0 declares dependency on json-glib-1.0>=1.4.4 #860

Closed
MocioF opened this issue Dec 21, 2024 · 1 comment · Fixed by #863
Closed

gvm-libs-22.15.0 declares dependency on json-glib-1.0>=1.4.4 #860

MocioF opened this issue Dec 21, 2024 · 1 comment · Fixed by #863
Labels

Comments

@MocioF
Copy link
Contributor

MocioF commented Dec 21, 2024

gvm-libs-22.15.0 marks as required json-glib-1.0>=1.4.4

pkg_check_modules (GLIB_JSON REQUIRED json-glib-1.0>=1.4.4)

The commit message of b9aa11d states "Replace libjson-glib with libcjson", but I don't see libjson-glib used nor linked by gvm-libs.

See: gentoo/gentoo#39801 (comment)

Is this a wrong dependency declaration?

libjson-glib is linked in openvas-scanner
https://github.com/greenbone/openvas-scanner/blob/a9e3aadc508ed3799d1dcf696927cd864339091a/misc/table_driven_lsc.c#L23
https://github.com/greenbone/openvas-scanner/blob/a9e3aadc508ed3799d1dcf696927cd864339091a/misc/ipc.c#L14

but it doesn't seems to be used in gvm-libs.

Expected behavior

gvm-libs should build without libjson-glib

Actual behavior

gvm-libs fails to build without libjson-glib

@MocioF MocioF added the bug label Dec 21, 2024
bjoernricks added a commit that referenced this issue Jan 8, 2025
json-glib as a requirement was introduced accidentally with the last
gvm-libs release but isn't used at all. Therefore remove the dependency
again.

Fixes #860
@bjoernricks
Copy link
Contributor

Thanks for the report. I removed the accidentally added dependency on json-glib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants