Fix Zig setup step in CI #1252
Fix Zig setup step in CI #1252
Conversation
| sudo mkdir /zig | ||
| curl 'https://ziglang.org/download/0.9.1/zig-linux-x86_64-0.9.1.tar.xz' | sudo tar xJ --strip-components=1 --directory=/zig | ||
| sudo ln -s /zig/zig /usr/bin/zig |
There was a problem hiding this comment.
Thanks for the fix!
Curious does this have to happen under root directory? If not, would sudo still be necessary?
There was a problem hiding this comment.
It's about installing for all users (need root permission) or installing for the current user (don't need permission). I think both of them are OK in CI.
There was a problem hiding this comment.
ahh right.. If you don't mind, i wonder if you could install it for the current user? (in general i'd want to minimize root access unless strictly necessary). Thanks!
There was a problem hiding this comment.
Ah the change is slightly more complicated than i thought.. Thanks a lot! :)
There was a problem hiding this comment.
lol do you have any simpler solutions?
There was a problem hiding this comment.
Not necessarily.. I was thinking maybe a local bin already exists and/or can be directly downloaded into.. but this works.. 😄
Fix the broken CI of building aarch64 binaries.
And I've tested it in my forked repo: https://github.com/hronro/grpc-web/actions/runs/2451424475