Consolidated shared schedule deletion functions

functions/package.json

@@ -6,7 +6,9 @@
     "format": "prettier \"**/*.{js,jsx,ts,tsx,json}\" --write",
     "format:check": "prettier \"**/*.{js,jsx,ts,tsx,json}\" -l",
     "build": "tsc",
+    "build:watch": "tsc -w",
     "serve": "npm run build && firebase emulators:start --project dev --only functions",
+    "serve:debug": "npm run build && firebase emulators:start --project dev --only functions --inspect-functions",
     "shell": "npm run build && firebase functions:shell --project dev",
     "start": "npm run shell",
     "deploy": "firebase deploy --only functions",

functions/src/create_friend_invitation.ts

@@ -105,12 +105,14 @@ export const createFriendInvitation = functions.https.onRequest(
             .json(apiError("Email does not exist in database"));
         }
 
+        const sortedVersions = versions.sort();
+
         // find and delete existing invites for the same sender, friend, term, and version
         const existingInvites = await invitesCollection
           .where("sender", "==", senderId)
           .where("friend", "==", friendId)
           .where("term", "==", term)
-          .where("versions", "==", versions)
+          .where("versions", "==", sortedVersions)
           .where("link", "==", false)
           .get();
         const batch = firestore.batch();
@@ -123,7 +125,7 @@ export const createFriendInvitation = functions.https.onRequest(
         const record: FriendEmailInviteData = {
           sender: senderId,
           term,
-          versions,
+          versions: sortedVersions,
           created: admin.firestore.Timestamp.fromDate(new Date()),
           link: false,
           validFor: 7 * 24 * 60 * 60,
@@ -133,7 +135,7 @@ export const createFriendInvitation = functions.https.onRequest(
         try {
           // Add the invite data to the schedule of the sender
           const addRes = await invitesCollection.add(record);
-          versions.forEach((v) => {
+          sortedVersions.forEach((v) => {
             if (!senderData.terms[term].versions[v].friends) {
               senderData.terms[term].versions[v].friends = {};
             }

functions/src/create_friend_invitation_link.ts

@@ -81,11 +81,13 @@ export const createFriendInvitationLink = functions.https.onRequest(
             .json(apiError("Cannot make link for invalid schedule version"));
         }
 
+        const sortedVersions = versions.sort();
+
         // find and delete existing links for the same sender, term, and version
         const existingInvites = await invitesCollection
           .where("sender", "==", senderId)
           .where("term", "==", term)
-          .where("versions", "==", versions)
+          .where("versions", "==", sortedVersions)
           .where("link", "==", true)
           .where("validFor", "==", validFor)
           .get();
@@ -99,7 +101,7 @@ export const createFriendInvitationLink = functions.https.onRequest(
         const record: FriendInviteData = {
           sender: senderId,
           term,
-          versions,
+          versions: sortedVersions,
           created: admin.firestore.Timestamp.fromDate(new Date()),
           link: true,
           validFor,