Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer for Github Polling is Missing #1560

Closed
nathannaveen opened this issue Dec 7, 2023 · 0 comments · Fixed by #1678
Closed

Timer for Github Polling is Missing #1560

nathannaveen opened this issue Dec 7, 2023 · 0 comments · Fixed by #1678
Labels
enhancement New feature or request

Comments

@nathannaveen
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The Polling option for the Github API is missing a ticker

collectorOpts = append(collectorOpts, github.WithPolling(30*time.Second))

So the polling option is never re-running, causing the polling flag to do nothing.

Describe the solution

The solution to this is to use a timer to keep on re-running, similar to

tickInterval := 30 * time.Second
ticker := time.NewTicker(tickInterval)

@nathannaveen nathannaveen added the enhancement New feature or request label Dec 7, 2023
nathannaveen added a commit to nathannaveen/guac that referenced this issue Dec 22, 2023
nathannaveen added a commit to nathannaveen/guac that referenced this issue Jan 31, 2024
nathannaveen added a commit to nathannaveen/guac that referenced this issue Jan 31, 2024
nathannaveen added a commit to nathannaveen/guac that referenced this issue Mar 6, 2024
nathannaveen added a commit to nathannaveen/guac that referenced this issue Mar 6, 2024
nathannaveen added a commit to nathannaveen/guac that referenced this issue Mar 6, 2024
nathannaveen added a commit to nathannaveen/guac that referenced this issue Mar 6, 2024
@kodiakhq kodiakhq bot closed this as completed in #1678 Mar 6, 2024
kodiakhq bot pushed a commit that referenced this issue Mar 6, 2024
arorasoham9 pushed a commit to arorasoham9/guac that referenced this issue Apr 1, 2024
arorasoham9 pushed a commit to arorasoham9/guac that referenced this issue Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant