-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timer for Github Polling is Missing #1560
Labels
enhancement
New feature or request
Comments
nathannaveen
added a commit
to nathannaveen/guac
that referenced
this issue
Dec 22, 2023
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
nathannaveen
added a commit
to nathannaveen/guac
that referenced
this issue
Jan 31, 2024
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
nathannaveen
added a commit
to nathannaveen/guac
that referenced
this issue
Jan 31, 2024
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
6 tasks
nathannaveen
added a commit
to nathannaveen/guac
that referenced
this issue
Mar 6, 2024
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
nathannaveen
added a commit
to nathannaveen/guac
that referenced
this issue
Mar 6, 2024
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
nathannaveen
added a commit
to nathannaveen/guac
that referenced
this issue
Mar 6, 2024
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
nathannaveen
added a commit
to nathannaveen/guac
that referenced
this issue
Mar 6, 2024
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
kodiakhq bot
pushed a commit
that referenced
this issue
Mar 6, 2024
* Fixes #1560 Signed-off-by: nathannaveen <[email protected]>
arorasoham9
pushed a commit
to arorasoham9/guac
that referenced
this issue
Apr 1, 2024
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
arorasoham9
pushed a commit
to arorasoham9/guac
that referenced
this issue
Apr 4, 2024
* Fixes guacsec#1560 Signed-off-by: nathannaveen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The Polling option for the Github API is missing a ticker
guac/cmd/guaccollect/cmd/github.go
Line 84 in 2b1e1ae
So the polling option is never re-running, causing the polling flag to do nothing.
Describe the solution
The solution to this is to use a timer to keep on re-running, similar to
guac/cmd/guacone/cmd/osv.go
Lines 92 to 93 in 2b1e1ae
The text was updated successfully, but these errors were encountered: