This repository was archived by the owner on Nov 23, 2023. It is now read-only.
Switch to using build.sbt, revel in auto-plugin happiness #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using .sbt build definitions (rather than .scala definitions) has been the recommended way of defining SBT projects since SBT v0.13.12, for all project types, including multi-project builds. Using auto-plugins is much nicer with .sbt build definitions - the necessary imports are all automatically made for you. It's become fiddlier to do .scala-based build definitions because plugin authors no longer document what those necessary imports are! I've deliberately tried to not shift too many files round with this commit, but at some point it would be nice to bring the sole `frontend` subproject up to the root level. http://notes.implicit.ly/post/147554513094/sbt-01312 http://www.scala-sbt.org/0.13/docs/Basic-Def.html https://groups.google.com/d/msg/sbt-dev/S-pr2nZQ3KY/iX9q3cbrHVQJ
This deploy has failed due to sbt/sbt-native-packager#759 - it's affected two successive builds (10075 & 10077) I notice that we seemed to find a fix for the issue with |
rtyley
added a commit
that referenced
this pull request
Oct 26, 2016
Deployment of PR #1358 failed due to sbt/sbt-native-packager#759, where jars in an artifact built with native packager occurred twice within the zip file. #1358 (comment) On the recommendation of Nepomuk Seiler, we tried using `useNativeZip` on a different project: guardian/members-data-api#100 ...and it seemed to help.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using .sbt build definitions (rather than .scala definitions) has been the recommended way of defining SBT projects since SBT v0.13.12, for all project types, including multi-project builds.
Using auto-plugins is much nicer with .sbt build definitions - the necessary imports are all automatically made for you. It's become fiddlier to do .scala-based build definitions because plugin authors no longer document what those necessary imports are!
I've deliberately tried to not shift too many files round with this commit, but at some point it would be nice to bring the sole
frontendsubproject up to the root level.http://notes.implicit.ly/post/147554513094/sbt-01312
http://www.scala-sbt.org/0.13/docs/Basic-Def.html
https://groups.google.com/d/msg/sbt-dev/S-pr2nZQ3KY/iX9q3cbrHVQJ
cc @paulbrown1982 @AWare