Use .deb for deployment #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Feb 14, 2017
build.sbt
Outdated
| @@ -36,16 +38,26 @@ libraryDependencies ++= Seq( | |||
|
|
|||
| scalacOptions ++= Seq("-feature") | |||
|
|
|||
| javaOptions in Universal ++= Seq( | |||
| s"-Dpidfile.path=/dev/null" | |||
There was a problem hiding this comment.
sbt-native-packager maintainer recommends to let play not handle the pid file: sbt/sbt-native-packager#377 (comment)
sihil
approved these changes
Feb 14, 2017
cloudformation/prism.template
Outdated
| "#!/bin/bash -ev\n", | ||
| "/opt/features/native-packager/install.sh -b deploy-tools-dist -s -t tgz\n" | ||
| "#!/bin/bash -ev", | ||
| "mkdir /prism", |
build.sbt
Outdated
| javaOptions in Universal ++= Seq( | ||
| s"-Dpidfile.path=/dev/null" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Does this need @philwills recommended options? See something like https://github.com/guardian/membership-frontend/blob/master/frontend/build.sbt#L60-L68
| def env(key: String): Option[String] = Option(System.getenv(key)) | ||
|
|
||
| lazy val root = (project in file(".")) | ||
| .enablePlugins(PlayScala, RiffRaffArtifact, UniversalPlugin) | ||
| .settings( | ||
| packageName in Universal := normalizedName.value, | ||
| maintainer := "Guardian Developers <[email protected]>", |
There was a problem hiding this comment.
We should create an email address for tools, but this will do for now.
cloudformation/prism.template
Outdated
| "mkdir /prism", | ||
| { "Fn::Join": [ "", [ "aws --region eu-west-1 s3 cp s3://deploy-tools-dist/deploy/", { "Ref": "Stage" }, "/prism/prism.deb /prism/" ] ] }, | ||
| "dpkg -i /prism/prism.deb", | ||
| "systemctl start prism" |
There was a problem hiding this comment.
In general I'd love to aim for userdata zero as I think there lies potential for more reusable CFN templates - but that's not enormously relevant here, just my philosophy.
TBonnin
force-pushed
the
tb-deb-package
branch
from
747680d to
83be5bd
Compare
TBonnin
force-pushed
the
tb-deb-package
branch
from
83be5bd to
b049693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies prism to use .deb for deployment. This is necessary to move away from machine-images to amigo
Tested in CODE