Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for another try, this time with perf #493

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

royvanrijn
Copy link
Contributor

Started running perf, perhaps this helps. No idea how to use it yet; but I guess lower is better and hope for the best?

Line numbers for hash collisions: 388 onwards, the matchers* methods.

Check List:

  • Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • All formatting changes by the build are committed
  • Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • Output matches that of calculate_average_baseline.sh
  • For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)
  • Execution time:
  • Execution time of reference implementation:

Started running perf, perhaps this helps. No idea how to use it yet
@gunnarmorling
Copy link
Owner

Nice! Triple-shared 3rd place now!

Benchmark 1: timeout -v 300 ./calculate_average_royvanrijn.sh 2>&1
  Time (mean ± σ):      2.571 s ±  0.023 s    [User: 17.311 s, System: 0.753 s]
  Range (min … max):    2.535 s …  2.608 s    10 runs

Summary
  royvanrijn: trimmed mean 2.571436178635, raw times 2.55616404126,2.54775638326,2.5975356672600003,2.5718475612600002,2.5348511522600004,2.60803711526,2.55915286826,2.57750082626,2.57017819426,2.59135388726

Leaderboard

| # | Result (m:s.ms) | Implementation     | JDK | Submitter     | Notes     |
|---|-----------------|--------------------|-----|---------------|-----------|
|   | 00:02.571 | [link](https://github.com/gunnarmorling/1brc/blob/main/src/main/java/dev/morling/onebrc/CalculateAverage_royvanrijn.java)| 21.0.1-graal | [Roy van Rijn](https://github.com/royvanrijn) | GraalVM native binary |

@gunnarmorling gunnarmorling merged commit 7c983f3 into gunnarmorling:main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants