Improved integer conversion, delayed string creation. #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, is this actually faster on your system? On the eval system it's ~19 sec now. |
|
start my linux in "init 3" defaults the results, now if the time is correct 14 seconds |
|
How is this dealing with hash collisions actually? It seems if two station names yield the same hash code, the aggregation would be wrong? |
|
I did several tests and there are no collisions between station names, but to prevent this I added the length of the string in the initialization of the hash.
|
|
Hum, I fail to understand how this resolves the issue. As a matter of principle it must be guaranteed that no values from several stations are mixed up, i.e. all potential collisions must be handled correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All test pass
new runtime 14 sec.