Autoclean instead of clean, fix bug with unpacking(Fix #63 and #64)

[EternityForest]

Fixes bugs:

#63 : unpack would chown the enture target dir with all existing files, and
#64 : apt-get clean would delete cached files that are still usable, eliminating caching between builds.

My simple solution for copying files involves unnecessary disk activity, but I think the bug is big enough to warrant fixing sooner rather than later, and then refining as time allows.

[guysoft]

Hey, so two things.
The unpack solution looks good. Worth merging.

Regarding the apt-clean, I think its worth adding an if there, and run autoclean if:

if [ -n "$BASE_APT_CACHE" ] && [ "$BASE_APT_CACHE" != "no" ]; then
  apt-get autoclean
else
  apt-get clean
fi

Do you want to update your branch? I can do it too but rather you have the commit author under you.

Because you want it to clean if you are not using a cache that is binded from outside.

[EternityForest]

Thank you for the feedback! I didn't know you supported non-bound caches.

I will update my branch accordingly!

[EternityForest]

Branch updated!

[guysoft]

Hey, I think this merge has effected the super large build at @zynthian which needs an extra of 10GB of storage. cc @jofemodo

I tried increasing the disk size there even further to see if that helps.

[jofemodo]

I must suppose the extra 10GB space we need is inside the SD image. This is a big problem for us ...
How can we solve it? Should we omit the CustomPiOS file copy mechanism and implement our own copy process, after the CustomPiOS finished?

[jofemodo]

Does exist a mechanism to prevent the image zip compression at the end of the CustomPiOS process?

[guysoft]

No, but I can add one. Open an issue. It will make me fix it. Like the image name I fixed. It should be quicker now.

[EternityForest]

Can we create another bind mounted temporary folder to hold the files while unpacking from the filesystem? Or would it be better to do it the more advanced way and manually iterate the files one by one? I don't know enough about bash to implement that with all the performance edge cases and such that might be hiding there, but it would be easy in Python3.

…

On Wed, Jan 15, 2020, 3:26 AM Guy Sheffer ***@***.***> wrote: No, but I can add one. Open an issue. It will make me fix it. Like the image name I fixed. It should be quicker now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#65?email_source=notifications&email_token=AAFZCHZF6W5HJ2ACI7UNZ3DQ53XHJA5CNFSM4J4VFY3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI77XSA#issuecomment-574618568>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFZCH6YTULGGBOPSUDLIJ3Q53XHJANCNFSM4J4VFY3A> .

[jofemodo]

Done! => #66