Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure description of devtools::check() is accurate re: NOT_CRAN #612

Closed
jennybc opened this issue Dec 8, 2019 · 2 comments
Closed

Comments

@jennybc
Copy link
Collaborator

jennybc commented Dec 8, 2019

devtools::check() does NOT in fact set NOT_CRAN. Some of the most common ways of running devtools::check() do set NOT_CRAN=true: namely, the RStudio Build pane and r-travis. But NOT_CRAN will not be set for a call to devtools::check() in the Console, unless the user has made explicit effort to do so.

r-lib/devtools#2135

Rewording is needed in this vicinity:

* Sets the `NOT_CRAN` environment variable to `TRUE`. This allows you to

@jimhester
Copy link
Contributor

Actually after r-lib/devtools@4663004 devtools::check() will set NOT_CRAN now. If we want I can do a devtools release before rstudio::conf with this change.

@jennybc
Copy link
Collaborator Author

jennybc commented Dec 9, 2019

OK great @jimhester. I'll leave the release timing to you, but it's clear that the wording in R Packages is faithful to devtools past and current intent and, in due course, the next devtools release.

@jennybc jennybc closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants