Skip to content

Commit

Permalink
Set NOT_CRAN by default during devtools::check()
Browse files Browse the repository at this point in the history
Fixes #2135
  • Loading branch information
jimhester committed Dec 5, 2019
1 parent 751b8cf commit 4663004
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# devtools (development version)

* `check_win_*()` function now resets the email to the original email after execution (@muschellij2, #2152).
* `check()` now sets `NOT_CRAN=true` by default, as was originally intended
(#2135).

* `test()` now takes `stop_on_failure` as a formal argument (FALSE by default)
instead of in `...`. Its value is still passed to `testthat::test_dir` as
before (@infotroph, #2129).
Expand Down
2 changes: 1 addition & 1 deletion R/check.R
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ check <- function(pkg = ".",
force_suggests = FALSE,
run_dont_test = FALSE,
args = "--timings",
env_vars = NULL,
env_vars = c(NOT_CRAN = "true"),
quiet = FALSE,
check_dir = tempdir(),
cleanup = TRUE,
Expand Down

0 comments on commit 4663004

Please sign in to comment.