Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen FSharp.Core version requirement #458

Closed
cmeeren opened this issue Jun 14, 2023 · 2 comments · Fixed by #459
Closed

Loosen FSharp.Core version requirement #458

cmeeren opened this issue Jun 14, 2023 · 2 comments · Fixed by #459

Comments

@cmeeren
Copy link

cmeeren commented Jun 14, 2023

Expecto 10.0.0 requires FSharp.Core = 7.0.200 (exact version). It should be >= (minimum version). I am using 7.0.300 in all projects, and therefore can't update Expecto.
@ratsclub
Copy link
Collaborator

Hello, @cmeeren. Thanks for reporting this! Would you mind opening a PR with this fix, please?

@cmeeren
Copy link
Author

cmeeren commented Jun 15, 2023 •
edited
Loading

Sorry, I'm swamped for the time being. If it's possible to change directly on GitHub and you tell me where, I can do it, but at that point it's probably quicker to just do it yourself. I'm guessing this is a single-character change somewhere.

JohnTheGr8 added a commit to JohnTheGr8/expecto that referenced this issue Jun 20, 2023
@JohnTheGr8
loosen FSharp.Core version requirement (fixes haf#458)
b5a8620
@JohnTheGr8 JohnTheGr8 mentioned this issue Jun 20, 2023
Merged
@farlee2121 farlee2121 mentioned this issue Jun 21, 2023
Closed
farlee2121 added a commit that referenced this issue Jun 22, 2023
@JohnTheGr8 @farlee2121
Loosen FSharp.Core version requirement (#459)
31343ce 
* loosen FSharp.Core version requirement (fixes #458)

* Allow any higher version for FSharp.Core

Before the net6.0 upgrade we allowed any FSharp.Core >= 4.6.0.
This is more consistent with that package behavior.
FSharp.Core also upgrades major versions fairly often (once a year), but rarely introduces changes that wouldn't be backwards compatible for us.

---------

Co-authored-by: Spencer Farley <[email protected]>
@JohnTheGr8 JohnTheGr8 mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loosen FSharp.Core version requirement JohnTheGr8/expecto
2 participants
@cmeeren @ratsclub