Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed files and classes related to random number generation. #31

Merged

Conversation

heplesser
Copy link

@hakonsbm Here are some changes to class and file names. Would you merge them and then create a PR towards master, marking it as "Draft"? That way, others can also start to take a look.

@@ -35,7 +35,7 @@

// Includes from nestkernel
#include "nest_datums.h"
#include "random.h"
#include "../../nestkernel/random_generators.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nestkernel directory is already in the include path, so this can be

Suggested change
#include "../../nestkernel/random_generators.h"
#include "random_generators.h"

@hakonsbm hakonsbm merged commit f23c109 into hakonsbm:feature/cpp11-librandom Apr 24, 2020
@hakonsbm
Copy link
Owner

I have created nest#1549.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants