-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean Translation for Handlebars.js Documentation #145
Conversation
Awesome! Are there any Korean-speakers who can review out there? |
Is there anyone who can review what I translated? If not, I can ask developers around me. I'm curious about what process a review should take. |
Hi, sure, it can be informal. Someone should proof-read and suggest any corrections, or say if everything looks good; more that one person would be even better :) |
I have been asked to review a Korean translation document, and here are the results of my review. Here is an example:
src/ko/guide
Apart from the spacing errors, there are no awkward parts in the translation. |
@Seongjunsim Spacing error has been corrected. Thank you for your review. |
/ko/index.md file The above contents ::: playground If I commit and push with line breaks as shown above, it is saved without line breaks. What should I do? I need help. |
@Myunwoo hm usually a local git client issue, try reading that one: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings |
@papasmile Tahnk you so much! |
I reviewed the revised version. All translated sentences have been checked, including modifications to the demo button. |
thanks! |
Korean translation is now live at https://handlebarsjs.com/ko/ |
Description:
This PR adds a complete Korean translation of the Handlebars.js documentation. The translated content includes all sections of the original documentation, ensuring that Korean-speaking developers can easily understand and utilize Handlebars.js.
Changes:
Added a new directory src/ko with all translated files.
Updated the main documentation page to include a link to the Korean version.
Checklist:
☑️ All translated files are included.
☑️ Links to the Korean documentation are correctly placed.
☑️ Reviewed for accuracy and completeness.
Thank you for considering this PR.