-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues when setting sim_backend='gpu' and shader='rt' #886
Comments
Since you are using just one env anyway you should just use the physx_cpu backend which will run faster. |
Thanks for the quick answer. The single env is actually only for testing, I plan to run with a larger number of envs later on.
Maybe some error or warning should be added to
I saw there is a check in ManiSkill/mani_skill/envs/sapien_env.py Lines 246 to 249 in 3922a6f
Also, as a side note to this check: it will only check if the I could help add a PR if these settings are not supported right now and it is just the checks that should be updated. |
A PR would be appreciated, these checks are for sure outdated. We need an updated warning/error safeguard around these options mixing. Although possibly the error might be better handled in the cameras.py file which creates the camera and checks the shader used. It should be able to reference the maniskill scene object and check what the sim backend is and if it is a parallelized sim then complain if shader is RT as well. Given the number of considerations I might just handle this tomorrow though, there's quite a few edge cases and I also need to add a new dataclass to mark which sim_backends are "single python process but parallelized" (just physx_cuda atm). |
When running the test code below with the PickClutterYCB-v1 environment, the robot collapses at the origin in the recorded video. This issue occurs specifically when using both
sim_backend='gpu'
andshader='rt'
. Other combinations ofsim_backend
andshader
seem ok.Additionally, when changing
render_mode
from'sensors'
to'human'
in this setup, a runtime error is raised, indicating that modifying a scene is not allowed after creating the batched render system.Test code:
Screenshot of resulting video:
When changing
render_mode
to'human'
the error is:The text was updated successfully, but these errors were encountered: