[sync] release one rlock and change default value at getMaxPeerHeight #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlan35
reviewed
Jan 6, 2022
|
please fix travis. |
rlan35
approved these changes
Jan 6, 2022
|
This PR caused "Error: SyncStatus.TargetIndex is negative: /network/status: /network/status not attempting retry: unable to initialize asserter" on rosetta tests. |
|
Noted. Will come back to this later
…On Thu, Jan 6, 2022 at 5:24 PM Rongjian Lan ***@***.***> wrote:
This PR was causing "Error: SyncStatus.TargetIndex is negative:
/network/status: /network/status not attempting retry: unable to initialize
asserter" on rosetta tests.
—
Reply to this email directly, view it on GitHub
<#3973 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJSNLCDA64G4NQXHLV3OUPDUUY6GLANCNFSM5LM7IMGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
JackyWYX
force-pushed
the
sync_stuck_fix
branch
from
23cd94b to
a433d27
Compare
…Height to maxInt if error
JackyWYX
force-pushed
the
sync_stuck_fix
branch
from
a433d27 to
f010316
Compare
JackyWYX
changed the title
|
This PR has been tested on a few multiple RPC nodes and was confirmed to fix the node-sync status so far. With travis build fix, I'll merge that one now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Release one rlock when iterating peers in sync. And change the default return result of getMaxPeerHeight as max uint64
Test
Passed local tests.