add connection manager high water mark flag to boot node #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophoah
approved these changes
Jul 10, 2024
ONECasey
approved these changes
Jul 11, 2024
GheisMohammadi
force-pushed
the
boot/p2p_connmgr
branch
from
7e1eec4 to
5e2fcd9
Compare
Frozen
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The p2p connection manager has a notion of trimming excess connections when they pass the high watermark. This number should be higher for boot nodes. This PR adds a new flag to p2p host for boot nodes to adjust the high water mark.
The default is set to 900 which is given from libp2p default value for high water mark libp2p constants