Make retry on connect failure filter on gateway http route filter a bool rather than a bool pointer #19386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmurret
added
pr/no-changelog
4 tasks
sarahalsmiller
approved these changes
Oct 26, 2023
jmurret
force-pushed
the
jm/retry-on-connect-failure
branch
from
2826dd3 to
e175e91
Compare
…ool rather than a bool pointer
jmurret
force-pushed
the
jm/retry-on-connect-failure
branch
from
e175e91 to
4a2fc73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
TestHTTPRouteRetryAndTimeoutfailure that is blocking #19365.Description
Testing & Reproduction steps
Links
PR Checklist