Add Read instance for PortNumber.

[bjornbm]

No description provided.

[eborden]

@kazu-yamamoto What do you think of this one? It has been languishing for a while. I see no reason not to merge it.

[kazu-yamamoto]

I support this. If we have doctest test cases, it would be much better.

[eborden]

Indeed @bjornbm do you have interest in writing these? Otherwise I can handle it.

[bjornbm]

I wouldn't say I have an “interest” per se and am pretty swamped so you are welcome to handle it if you have the time. :)

Question: Where would the test go? The instance cannot have haddocks (unless things have changed recently?) and I don't see any doctests at the PortNumber definition, nor for the Show instance. Where should I be looking? Thanks

[kazu-yamamoto]

I will take this. doctest does not exsit at this moment. So, I will merge this first. Then I will add doctest test suite and add doctest test cases for this.

[kazu-yamamoto]

Please check two patches above.

[kazu-yamamoto]

Pinging @eborden and @bjornbm.

[bjornbm]

Sorry but I'm on travel and don't have a Haskell system available to test this the next two weeks.

[kazu-yamamoto]

Pinging @eborden and @bjornbm again.

@eborden We need to release a new version ASAP.

[eborden]

This all looks good to me!