Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement products #6

Merged
merged 50 commits into from
Mar 17, 2025
Merged

Implement products #6

merged 50 commits into from
Mar 17, 2025
+412 −6

Conversation

iwei20
Copy link
Contributor

@iwei20 iwei20 commented Mar 9, 2025

No way to eliminate them, though

iwei20 added 30 commits March 6, 2025 23:34
@iwei20
Add product form, type, and action
962e36c
@iwei20
Add LProduct and RProduct variants for Ztyp
5b0f939
@iwei20
Fix reversed Ztyp and Htyp constructor for RProduct
6cee5e4
@iwei20
Add consistency check between products
42bb3e7
@iwei20
Add Product definitions to .rei interfaces
84f7c33
@iwei20
Add Product to naive _capture_name_body
8de584e
@iwei20
Add Product to delete_middle
872e51b
@iwei20
Add action application for types on products
7a486ce
@iwei20
Add WrapProduct to _string_of_action
57c77fc
@iwei20
Add WrapProduct action application
f934af4
@iwei20
Add Product to MoveDown
b7395e7
@iwei20
Add Product to Unwrap action
d0b0e57
@iwei20
Add bareExp Product
5a5850c
@iwei20
Add Iexp to bareExp Product erasing
84c12cb
@iwei20
Add Product markedExp
7c06f96
@iwei20
Add Product to performance_mark_syn
02ed0da
@iwei20
Add Product to validity marking
64e1e95
@iwei20
Add string_of_action for WrapProduct
88425c7
@iwei20
Add Product Pexp
9581773
@iwei20
Add Product to pexp_of_htyp
139e432
@iwei20
Add pexp_of_ztyp for Product
e00e765
@iwei20
Add Product precedence
1a1d7ed
@iwei20
Add Product to assoc
53ddbb1
@iwei20
Add Product to pexp_of_iexp_middle
13b0dbd
@iwei20
Add string_of_pexp for Product
bfa443f
@iwei20
Fix a comma
657dcdc
@iwei20
Add button for product wrap
0cb32ef
@iwei20
Implement update step for products properly
c723747
@iwei20
Fix remarking for products
f4b7e58
@iwei20
Fix moving up in product types
1f3530a
iwei20 added 18 commits March 9, 2025 17:54
@thomasporter522
Copy link
Contributor

Looking good so far! Can you:

  • Fix Wrap Pair (Left), it currently seems to do nothing
  • Add all new actions to the action generator in actions_random.re
  • Ensure that random tests with a lot of actions pass (as many as you can make run in a few seconds)

@thomasporter522 thomasporter522 self-assigned this Mar 17, 2025
@thomasporter522 thomasporter522 merged commit 84bc8da into master Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomasporter522 thomasporter522

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iwei20 @thomasporter522