cmake: Port PR25972 from the master branch #188
Conversation
Port PR25972.
Bump clang to version 16 in the "Linux 32-bit" CI job to avoid false positive `-Wunreachable-code` warnings. Link to libatomic is still required.
Switch to Ubuntu 24.04 that provides GCC 13 by default, which fixes false positive `-Wmaybe-uninitialized` warnings in the "Linux 64-bit, multiprocess" job.
.github/workflows/cmake.yml
Outdated
| exe_extension: '.exe' | ||
| - name: 'MinGW-w64, debug' | ||
| triplet: 'x86_64-w64-mingw32' | ||
| packages: 'g++-mingw-w64-x86-64-posix' | ||
| depends_options: 'DEBUG=1' | ||
| configure_options: '-DCMAKE_BUILD_TYPE=Debug' | ||
| configure_options: '-DCMAKE_BUILD_TYPE=Debug -DWERROR=ON -DCMAKE_CXX_FLAGS="-Wno-error=maybe-uninitialized"' |
There was a problem hiding this comment.
Are we not supposed to use the APPEND_CXXFLAGS for this?
There was a problem hiding this comment.
They are not merged into the staging branch yet.
The last commit has been dropped. |
|
I don't see how the last commit can be dropped, unless the CI here isn't equivalent to master? Otherwise it should now be failing with build errors? |
It is not. The The master branch CI script is to be restored in #142. |
|
I guess I don't understand why compilers are being changed to avoid warnings then? Why not just turn off Werror if the point isn't to match master? Rather than swap to a compiler we don't use? |
Yes. This can be done.
The number of developers, who uses Ubuntu 24.04, is expected to grow. Anyway, all CI stuff has to be resolved in #142. |
This PR ports bitcoin#25972 after the recent sync/rebase PR.