feat: deprecate enforcesemver2 config option #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuto
commented
Jan 22, 2022
| if err != nil { | ||
| // TODO: this is an error if invalid semver, making "EnforceSemver2" useless... | ||
| return filename, &HTTPError{http.StatusInternalServerError, err.Error()} |
There was a problem hiding this comment.
💭 While I get familiar with everything, should we return a 400 here and skip the call to ChartVersionFromStorageObject entirely? We don't need the version for anything anymore
There was a problem hiding this comment.
cool, fixed in 2f11e50!
cbuto
force-pushed
the
feat/deprecate-enforce-semver
branch
from
cdd5fec to
d4fc0e8
Compare
jdolitsky
requested changes
Jan 24, 2022
pkg/chartmuseum/server.go
Outdated
Comment on lines
139
to
142
| // EnforceSemver was deprecated, see https://github.com/helm/chartmuseum/issues/485 for more info | ||
| EnforceSemver2: options.EnforceSemver2, | ||
| Version: options.Version, | ||
| CacheInterval: options.CacheInterval, |
There was a problem hiding this comment.
Can you place it at the bottom of the struct, so we can have a section for deprecated?
| if err != nil { | ||
| // TODO: this is an error if invalid semver, making "EnforceSemver2" useless... | ||
| return filename, &HTTPError{http.StatusInternalServerError, err.Error()} |
Signed-off-by: Casey Buto <[email protected]>
Signed-off-by: Casey Buto <[email protected]>
cbuto
force-pushed
the
feat/deprecate-enforce-semver
branch
from
4894cdc to
2f11e50
Compare
|
Cool @cbuto , it really do me a favor 🥳 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #482 to fully "deprecate" the
--enforce-semver2flag. It seems like some of the documentation work is capture in #485, which I can follow up on.Also, do we want a way to mark config options as deprecated and print warnings if they are set on startup?