Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-223: fixes for NumPy 2 #224

Merged
merged 3 commits into from
Jan 31, 2025
Merged

gh-223: fixes for NumPy 2 #224

merged 3 commits into from
Jan 31, 2025

Conversation

ntessore
Copy link
Contributor

Fix for the removed ndarray.newbyteorder() method. Fixes for the Result warnings still TBD.

Closes: #223

@ntessore
Copy link
Contributor Author

There was a real bug hiding in __array_wrap__ :)

@ntessore ntessore marked this pull request as ready for review January 31, 2025 12:05
@ntessore ntessore requested review from JaimeRZP and ucapbba and removed request for JaimeRZP and ucapbba January 31, 2025 12:05
Saransh-cpp
Saransh-cpp approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ntessore! Looks good!

@ntessore ntessore merged commit 0c30d41 into main Jan 31, 2025
8 checks passed
@ntessore ntessore deleted the pr-223 branch January 31, 2025 18:56
@ntessore
Copy link
Contributor Author

Thanks @Saransh-cpp!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixes for NumPy 2
2 participants
@ntessore @Saransh-cpp