Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-226: new CovMatrix result type #230

Merged
merged 8 commits into from
Feb 5, 2025
Merged

gh-226: new CovMatrix result type #230

merged 8 commits into from
Feb 5, 2025

Conversation

JaimeRZP
Copy link
Contributor

@JaimeRZP JaimeRZP commented Feb 3, 2025

Adds an extra result class dedicated to save covariance matricies #226

@JaimeRZP JaimeRZP requested a review from ntessore February 4, 2025 09:35
@ntessore
Copy link
Contributor

ntessore commented Feb 4, 2025

pre-commit.ci run

@ntessore ntessore changed the title 226 covmatrix gh-226: new CovMatrix result type Feb 4, 2025
Copy link
Contributor

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just realised this: we do need weight_1 and weight_2 here, not one full weight matrix, according to what we discussed offline the other day.

@JaimeRZP
Copy link
Contributor Author

JaimeRZP commented Feb 5, 2025

@ntessore back to you!

@ntessore ntessore linked an issue Feb 5, 2025 that may be closed by this pull request
@ntessore ntessore merged commit 6d3b51c into main Feb 5, 2025
9 checks passed
@ntessore ntessore deleted the 226-covmatrix branch February 5, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add class for CovMatrix results
2 participants