-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update 10.0 alpha.1 #3078
Merged
Merged
update 10.0 alpha.1 #3078
+286
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added description for args in Domain commands * Added missing descriptions for args in Addons command topic * Added missing descriptions for args in Local command topic * Added missing descriptions for args in CI command topic * Added missing descriptions for args in the Certs command topic * Added missing descriptions for args in the Labs command topic * Added missing descriptions for args in the Spaces command topic * Added missing descriptions for args in the Apps command topic * Added missing descriptions for args in the Access command topic * Added missing descriptions for args in the Features command topic * Added missing descriptions for args in the Keys command topic * Added missing descriptions for args in the Sessions command topic * Added missing descriptions for args in the Members command topic * Added missing descriptions for args in the PG command topic * Added missing descriptions for args in the Config command topic * Added missing descriptions for args in the Webhooks command topic * Added missing descriptions for args in the Authorizations command topic * Added missing descriptions for args in the Redis and Releases command topic * Added missing descriptions for args in the Redis and Drains command topic * Added missing descriptions for args in the Dynos command topic * Added missing descriptions for args in the Clients command topic * Updated unit tests to include new descriptions * Updates from ux feedback * Updated database arg descriptions * Added PG database arg descriptions (#3054) * Added PG database arg descriptions * Update packages/cli/src/package.nls.json +1 Co-authored-by: Sandy Lai <[email protected]> * Update packages/cli/src/package.nls.json Co-authored-by: Sandy Lai <[email protected]> * Update packages/cli/src/package.nls.json Co-authored-by: Sandy Lai <[email protected]> * Update packages/cli/src/package.nls.json Co-authored-by: Sandy Lai <[email protected]> --------- Co-authored-by: Sandy Lai <[email protected]> * Updates from Sandy's feedback * Update packages/cli/src/commands/addons/plans.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/clients/info.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/clients/rotate.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/clients/update.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/backups/cancel.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/local/index.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/ci/info.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/test/unit/commands/ci/info.unit.test.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/kill.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/ci/rerun.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/copy.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/addons/open.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/apps/open.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/clients/create.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/clients/create.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/config/get.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/keys/remove.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/backups/delete.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/backups/download.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/backups/info.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/backups/restore.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/backups/url.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/copy.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/diagnose.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/pg/settings/auto-explain/log-min-duration.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/ps/restart.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/ps/stop.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/cli.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/credentials.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/info.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/keyspace-notifications.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/maintenance.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/maxmemory.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/promote.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/stats-reset.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/timeout.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/upgrade.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/redis/wait.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/spaces/drains/set.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/webhooks/info.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/commands/webhooks/update.ts Co-authored-by: Helen Cheng <[email protected]> * Update packages/cli/src/package.nls.json Co-authored-by: Helen Cheng <[email protected]> --------- Co-authored-by: Sandy Lai <[email protected]> Co-authored-by: Helen Cheng <[email protected]>
* Access status code from api error The `error` is an `HerokuAPIError` instance, so we need to access the status code accordingly * Check error type before accessing status code * Remove whitespace --------- Co-authored-by: Rune Soerensen <[email protected]>
dsouza-anush
approved these changes
Nov 8, 2024
justinwilaby
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.