Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 10.0 alpha.1 #3078

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Nov 8, 2024

No description provided.

justinwilaby and others added 3 commits November 6, 2024 09:27
* Added description for args in Domain commands

* Added missing descriptions for args in Addons command topic

* Added missing descriptions for args in Local command topic

* Added missing descriptions for args in CI command topic

* Added missing descriptions for args in the Certs command topic

* Added missing descriptions for args in the Labs command topic

* Added missing descriptions for args in the Spaces command topic

* Added missing descriptions for args in the Apps command topic

* Added missing descriptions for args in the Access command topic

* Added missing descriptions for args in the Features command topic

* Added missing descriptions for args in the Keys command topic

* Added missing descriptions for args in the Sessions command topic

* Added missing descriptions for args in the Members command topic

* Added missing descriptions for args in the PG command topic

* Added missing descriptions for args in the Config command topic

* Added missing descriptions for args in the Webhooks command topic

* Added missing descriptions for args in the Authorizations command topic

* Added missing descriptions for args in the Redis and Releases command topic

* Added missing descriptions for args in the Redis and Drains command topic

* Added missing descriptions for args in the Dynos command topic

* Added missing descriptions for args in the Clients command topic

* Updated unit tests to include new descriptions

* Updates from ux feedback

* Updated database arg descriptions

* Added PG database arg descriptions (#3054)

* Added PG database arg descriptions

* Update packages/cli/src/package.nls.json

+1

Co-authored-by: Sandy Lai <[email protected]>

* Update packages/cli/src/package.nls.json

Co-authored-by: Sandy Lai <[email protected]>

* Update packages/cli/src/package.nls.json

Co-authored-by: Sandy Lai <[email protected]>

* Update packages/cli/src/package.nls.json

Co-authored-by: Sandy Lai <[email protected]>

---------

Co-authored-by: Sandy Lai <[email protected]>

* Updates from Sandy's feedback

* Update packages/cli/src/commands/addons/plans.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/clients/info.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/clients/rotate.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/clients/update.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/backups/cancel.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/local/index.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/ci/info.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/test/unit/commands/ci/info.unit.test.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/kill.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/ci/rerun.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/copy.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/addons/open.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/apps/open.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/clients/create.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/clients/create.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/config/get.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/keys/remove.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/backups/delete.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/backups/download.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/backups/info.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/backups/restore.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/backups/url.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/copy.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/diagnose.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/pg/settings/auto-explain/log-min-duration.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/ps/restart.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/ps/stop.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/cli.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/credentials.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/info.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/keyspace-notifications.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/maintenance.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/maxmemory.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/promote.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/stats-reset.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/timeout.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/upgrade.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/redis/wait.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/spaces/drains/set.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/webhooks/info.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/commands/webhooks/update.ts

Co-authored-by: Helen Cheng <[email protected]>

* Update packages/cli/src/package.nls.json

Co-authored-by: Helen Cheng <[email protected]>

---------

Co-authored-by: Sandy Lai <[email protected]>
Co-authored-by: Helen Cheng <[email protected]>
* Access status code from api error

The `error` is an `HerokuAPIError` instance, so we need to access the status code accordingly

* Check error type before accessing status code

* Remove whitespace

---------

Co-authored-by: Rune Soerensen <[email protected]>
@eablack eablack requested a review from a team as a code owner November 8, 2024 18:00
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eablack eablack merged commit ec2587a into prerelease/10.0.0-alpha Nov 8, 2024
8 checks passed
@eablack eablack deleted the eb/update-10.0-alpha.1 branch November 8, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants