Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiro: Defer menubar updates on Windows to reduce flicker. #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Nov 17, 2020

Menu bar updates are deferred to the event loop. A special case is made when no menu bar is visible, to ensure one is visible as early as possible during application startup.

Old New
byuu with current hiro, menu flickers byuu with hiro from this PR, no menu flicker

Menu bar updates are deferred to the event loop. A special case is made
when no menu bar is visible, to ensure one is visible as early as
possible during application startup.
@bsnesFan
Copy link

This fix is working with bsnes as well. That's cool. =)

Do you think it is possible to fix this insane flickering issue in the settings there as well, @jchv

2021-02-23-14-01-43.mp4

@jchv
Copy link
Contributor Author

jchv commented Feb 23, 2021

I've looked into it but it may not be trivial. :)

@bsnesFan
Copy link

@jchv: Thank you very much for your response and that you looked into that! That's unfortunate. But what I realized is that ares has the same gui and it hasn't this problem anymore. Seems like Near changed something. Maybe you can see there what exactly the problem is. That would be really cool. That's basically the only thing that bothers me, when I'm using bsnes. ^^;

@setthh
Copy link

setthh commented Jul 31, 2021

He did something in this commit: bsnes-emu/bsnes@56c9a51
Maybe this will help to identify the problem.

And we have the source code of ares for comparison: https://github.com/higan-emu/ares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants