-
Notifications
You must be signed in to change notification settings - Fork 19
You can use GITHUB_TOKEN
already provided by Github Actions
#100
Conversation
Sorry for the question, since I'm far from familiar with GitHub Actions. Is this a better way to do it than what we were doing? Should we expect any changes in our pipeline with this change? Thanks for the PR :) |
Sorry @serras I should've give more context, Github Actions already creates a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better CI is better software!
Unfortunately the deployment failed https://github.com/higherkindness/mu-haskell/runs/416664329?check_suite_focus=true. The error is:
@alejandrohdezma could you have a look at this? In the meanwhile I'll revert the commit. |
@serras I'll take a look at it |
Hi! According to the documentation for that GitHub Action instead of:
it should be:
for using that token. |
Hey @rachelcarmena! After diving into this issue I think I was mistaken in the first place. As said in the plugin documentation:
So I think we have to stick with the custom token for now :( |
Oh, right! I didn't read the |
@alejandrohdezma @rachelcarmena thanks for clarifying the issue! I'll try to revert the PR, although it seems that the other part of our CI infrastructure (Cachix) is failing, so we might need to wait until @kutyel comes back from holidays. |
Reference: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/authenticating-with-the-github_token