Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

You can use GITHUB_TOKEN already provided by Github Actions #100

Merged
merged 1 commit into from
Jan 30, 2020
Merged

You can use GITHUB_TOKEN already provided by Github Actions #100

merged 1 commit into from
Jan 30, 2020

Conversation

alejandrohdezma
Copy link
Contributor

@serras
Copy link
Collaborator

serras commented Jan 29, 2020

Sorry for the question, since I'm far from familiar with GitHub Actions. Is this a better way to do it than what we were doing? Should we expect any changes in our pipeline with this change? Thanks for the PR :)

@alejandrohdezma
Copy link
Contributor Author

Sorry @serras I should've give more context, Github Actions already creates a GITHUB_TOKEN secret automatically for your workflows so you don't need to add one under Settings > Secrets

Copy link
Collaborator

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better CI is better software!

@serras serras merged commit 14c185d into higherkindness:master Jan 30, 2020
@serras
Copy link
Collaborator

serras commented Jan 30, 2020

Unfortunately the deployment failed https://github.com/higherkindness/mu-haskell/runs/416664329?check_suite_focus=true. The error is:

Load key "/root/.ssh/id_rsa": invalid format
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

@alejandrohdezma could you have a look at this? In the meanwhile I'll revert the commit.

@alejandrohdezma
Copy link
Contributor Author

@serras I'll take a look at it

@rachelcarmena
Copy link
Contributor

Hi! According to the documentation for that GitHub Action instead of:

ACTIONS_DEPLOY_KEY:

it should be:

GITHUB_TOKEN:

for using that token.

@alejandrohdezma
Copy link
Contributor Author

Hey @rachelcarmena! After diving into this issue I think I was mistaken in the first place. As said in the plugin documentation:

Currently, GitHub Actions does not support to trigger a GitHub Pages build event using GITHUB_TOKEN on a public repository.

So I think we have to stick with the custom token for now :(

@rachelcarmena
Copy link
Contributor

Oh, right! I didn't read the (1) 🤦‍♀️ sorry. Thanks!!

@serras
Copy link
Collaborator

serras commented Jan 31, 2020

@alejandrohdezma @rachelcarmena thanks for clarifying the issue! I'll try to revert the PR, although it seems that the other part of our CI infrastructure (Cachix) is failing, so we might need to wait until @kutyel comes back from holidays.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants