Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch python3.10 to dev version #516

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Switch python3.10 to dev version #516

merged 1 commit into from
Apr 13, 2021

Conversation

davfsa
Copy link
Member

@davfsa davfsa commented Apr 4, 2021 •
edited
Loading

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

@davfsa davfsa added the devops Changes to quality control processes, CI, release processes label Apr 4, 2021
@davfsa davfsa requested a review from FasterSpeeding April 4, 2021 08:22
@davfsa davfsa self-assigned this Apr 4, 2021
@davfsa davfsa force-pushed the task/python3.10-dev branch 6 times, most recently from 523248c to a33cfb1 Compare April 4, 2021 09:51
@davfsa davfsa mentioned this pull request Apr 4, 2021
Closed
@FasterSpeeding
Copy link
Collaborator

FasterSpeeding commented Apr 4, 2021 •
edited
Loading

The tests just aren't gonna run until python/typed_ast#155 is released if we bump to 3.10.0-apha6 or above, is that really what we want?

@davfsa
Copy link
Member Author

davfsa commented Apr 4, 2021

The tests just aren't gonna run until python/typed_ast#155 if we bump to 3.10.0-apha6 or above, is that really what we want?

That bug got fixed on master and could be fixed at any time, which is why I would have this one merged so we can just have pipelines running to try and pass on 3.10

@FasterSpeeding
Copy link
Collaborator

FasterSpeeding commented Apr 4, 2021 •
edited
Loading

The tests just aren't gonna run until python/typed_ast#155 if we bump to 3.10.0-apha6 or above, is that really what we want?

That bug got fixed on master and could be fixed at any time, which is why I would have this one merged so we can just have pipelines running to try and pass on 3.10

Could we just temporarily target a specific commit on their repo to override the ver out dependency is depending on until they release the change?

@davfsa davfsa changed the title Switch python3.10 to dev version and allow failure Switch python3.10 to dev version Apr 4, 2021
@davfsa davfsa force-pushed the task/python3.10-dev branch from a33cfb1 to 7a659da Compare April 4, 2021 21:13
@davfsa davfsa marked this pull request as draft April 9, 2021 10:41
@davfsa
Copy link
Member Author

davfsa commented Apr 9, 2021

aio-libs/aiohttp#5604

I'm thinking on just not installing aiodns on Python3.10. @FasterSpeeding opinions?

@davfsa davfsa force-pushed the task/python3.10-dev branch 2 times, most recently from c36b52a to 5d9ac9a Compare April 12, 2021 19:58
@davfsa davfsa marked this pull request as ready for review April 12, 2021 20:07
@davfsa
Switch python3.10 to dev version
f09aec4 
  - Don't install aiodns on python3.10+
@davfsa davfsa force-pushed the task/python3.10-dev branch from 5d9ac9a to f09aec4 Compare April 12, 2021 20:16
@FasterSpeeding
Copy link
Collaborator

FasterSpeeding commented Apr 13, 2021 •
edited
Loading

Would it be worth it opening an issue here to track how to properly deal with aiodns on 3.10 in the long term even if it ends up being a long hanging one just so we dont forget about it?

@davfsa davfsa mentioned this pull request Apr 13, 2021
Closed
@davfsa davfsa merged commit e4678bd into hikari-py:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FasterSpeeding FasterSpeeding Awaiting requested review from FasterSpeeding FasterSpeeding is a code owner

Assignees

@davfsa davfsa

Labels
devops Changes to quality control processes, CI, release processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davfsa @FasterSpeeding