Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checks for null 'review link' and 'final asset' #122

Merged
merged 1 commit into from
Jun 12, 2024
Merged

add checks for null 'review link' and 'final asset' #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions blocks/gmo-program-details/gmo-program-details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,10 @@ async function buildTableRow(deliverableJson, kpi, createHidden) {
<div class='property table-column column2 deliverable-type'>${checkBlankString(typeLabel)}</div>
<div class='property table-column column3 platforms'></div>
<div class='property table-column column4 review-link'>
<a href="${deliverableJson.reviewLink}" class="campaign-link" target="_blank">Review Link</a>
${deliverableJson.reviewLink ? '<a href="' + deliverableJson.reviewLink + '"target="_blank" class="campaign-link">Review Link</a> ': "Not Available"}
</div>
<div class='property table-column column5'>
${deliverableJson.linkedFolderLink ? '<a href="' + deliverableJson.linkedFolderLink + '"target="_blank" class="campaign-link">Final Asset</a> ': "Not Available"}
</div>
<div class='property table-column column7 justify-center'>
<div class='status-wrapper'>
Expand All @@ -508,14 +509,6 @@ async function buildTableRow(deliverableJson, kpi, createHidden) {
</div>
<div class='property table-column column9'>${checkBlankString(deliverableJson.driver)}</div>
`;
if (!(deliverableJson.linkedFolderLink == null)) {
const finalAssetLink = document.createElement('a');
finalAssetLink.href = deliverableJson.linkedFolderLink;
finalAssetLink.classList.add('campaign-link');
finalAssetLink.target = '_blank';
finalAssetLink.textContent = "Final Asset";
dataRow.querySelector('.column5').appendChild(finalAssetLink);
}
createPlatformString(deliverableJson.platforms, dataRow);
return dataRow;
}
Expand Down
Loading