Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Asset Modal #46

Merged
merged 119 commits into from
Mar 14, 2024
Merged

Add Asset Modal #46

merged 119 commits into from
Mar 14, 2024

Conversation

mathieu-lessard
Copy link
Collaborator

synox and others added 30 commits November 22, 2023 17:08
@synox
fix: update fstab
b268606
@synox
Update README.md
a9c30b8
@synox
Merge branch 'main' of github.com:adobe/assets-distribution-portal
7a78ad3
@synox
Merge branch 'main' of github.com:adobe/assets-distribution-portal
58fc064
@synox
ASSETS-3207 integrate Unified shell (#3)
d7a0175
@synox
ASSETS-32004 use discovery service to find instances with content hub…
2ca4993 
… product profiles (#4)

* ASSETS-31822
Create separate security module for Unified Shell

* Setup delivery endpoint discovery
@synox
docs: update readme
767ba48
@synox
docs: update readme
bdebb31
@synox
chore: allow showing 404 page
6c659b8
@synox
chore: update sidekick host
c88161b
@synox
chore: remove old comment
6022945
@synox
fix: update serviceCode===dma_aem_contenthub
62cb628
@synox
fix: don't open browser on "aem up"
f3457f3
@synox
Merge branch 'main' of github.com:adobe/assets-distribution-portal
779f0c0
@synox
ASSETS-32078: Handle changes of imsOrg from Unified Shell
917063b
@synox
Show spinner while imsOrg changes
5f59359
@synox
fix: use delivery urls from discovery
2c497f6
@synox
fix: use delivery urls from discovery
d38c0cc
@synox
refactor: use page.iframeReload(false);
fc4b48e
@synox
adapt 404 error page for Unified Shell
43c8742
@synox
feat: reflect url changes from unified shell in app
2346009
@synox
ASSETS-32075 Hide header bar (logo, user switcher) when using Unified…
03e23d4 
… Shell (#5)
@synox
ASSETS-32055: POC integration with Upload MFE (#8)
7c57ff6
@synox
ASSETS-32055: provide bearer token
5b714b1
@synox
chore: remove dialog after closing
90c3c56
@andrewmkhoury
ASSETS-31831 - Portal style changes for content hub (#6)
affa0ce
@synox
chore: fix typo in jsdocs: BrandingConfig.portalTheme
fc21740
@synox
Merge branch 'main' of github.com:adobe/assets-distribution-portal
0e54d7e 
# Conflicts:
#	scripts/security.js
Load Reporting MFE using pure JS
472411e
Add css
15a45d8
klcodanr and others added 15 commits January 10, 2024 14:54
@klcodanr
Styling tweaks to the upload dialog
12b2864
@staware30
Commented out ProductFamily from 'Add Asset' (#30)
528d712
@staware30
Alphabetize Product List on 'Add Assets' Modal (#32)
ad4c2fe
@mathieu-lessard
DXI-23343: New Multi-required fields. Enable upload on form filled (#34)
a27d002 
Co-authored-by: Mathieu Lessard <[email protected]>
@mathieu-lessard
DXI-23346: Hydration uses values from Algolia for selections (#35)
989e54c 
* DXI-23346: Hydration uses values from Algolia for selections

* Adjusted spacing

* Adjusted spacing

---------

Co-authored-by: Mathieu Lessard <[email protected]>
@mathieu-lessard
Updated Asset Upload Experience (#37)
d02b9e7 
* Updated Asset Upload Experience

* Added comment regarding why the button change is delayed

---------

Co-authored-by: Mathieu Lessard <[email protected]>
Enabled Perpetuity Option
87c1452
Fixed license date to use ISO instead of epoch
d816fb8
Refactored code
27bfdc9
@cheintzman
'Add Assets' button can now be hidden by IMS group (#44)
7293e19 
- Added checkAddAssetsAccess() that will compare 'imsAuthorGroup' in 'admin-config.xlsx' in sharepoint to the IMS groups of the current user.
- Code that loads the 'Add Assets' button will now not execute unless checkAddAssetsAccess() returns true.
Removed Keywords from Asset Upload
40191c9
Renamed LisenceDate Property
73743f1
Renamed LisenceDate Property
353f504
Merge branch 'chdemo' of https://github.com/hlxsites/adobe-gmo into c…
1197aa9 
…hdemo
Merge remote-tracking branch 'origin/HEAD' into chdemo
26f65a6
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 14, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 14, 2024 •
edited
Loading

Page Scores Audits Google
/qa/assets PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

cheintzman
cheintzman approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@cheintzman cheintzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. LGTM!

@mathieu-lessard mathieu-lessard merged commit 41d54c6 into main Mar 14, 2024
0 of 2 checks passed
mathieu-lessard added a commit that referenced this pull request Mar 14, 2024
@mathieu-lessard
Revert "Add Asset Modal (#46)"
0caac86 
This reverts commit 41d54c6.
@mathieu-lessard mathieu-lessard mentioned this pull request Mar 14, 2024
Merged
mathieu-lessard added a commit that referenced this pull request Mar 14, 2024
@mathieu-lessard
Revert "Add Asset Modal (#46)" (#47)
171c405 
This reverts commit 41d54c6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiv-gup shiv-gup shiv-gup approved these changes

@cheintzman cheintzman cheintzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mathieu-lessard @shiv-gup @cheintzman @synox @andrewmkhoury @lsun-adobe @SUNLINGLING98 @klcodanr @staware30