Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIOMAGE-1230] - Test launch analysis #10

Merged
merged 40 commits into from
Sep 10, 2021
Merged

[BIOMAGE-1230] - Test launch analysis #10

merged 40 commits into from
Sep 10, 2021

Conversation

aerlaut
Copy link
Contributor

@aerlaut aerlaut commented Aug 18, 2021

Background

Link to issue

https://biomage.atlassian.net/browse/BIOMAGE-1230

Link to staging deployment URL

N.A.

Links to any Pull Requests related to this

UI - hms-dbmi-cellenics/ui#466

Anything else the reviewers should know about the changes here

  • Added command to choose a project
  • Added command to launch analysis

Changes

Code changes

Definition of DONE

Your changes will be ready for merging after each of the steps below have been completed:

Testing

  • Unit tests written
  • Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
  • Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils

Documentation updates

Is all relevant documentation updated to reflect the proposed changes in this PR?

  • Relevant Github READMEs updated
  • Relevant wiki pages created/updated

Approvers

  • Approved by a member of the core engineering team
  • (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

Optional

  • Photo of a cute animal attached to this PR

@ivababukova
Copy link
Member

ivababukova commented Sep 10, 2021 via email

@aerlaut
Copy link
Contributor Author

aerlaut commented Sep 10, 2021

Can you remove the ticket that you created for this too then?

On Fri, Sep 10, 2021 at 8:55 AM Anugerah Erlaut @.> wrote: @.* commented on this pull request. ------------------------------ In e2e/cypress/integration/ui-smoke/ui-launch-analysis.spec.js <#10 (comment)>: > + Cypress.on('uncaught:exception', (err) => { + if (resizeObserverLoopErrRe.test(err.message)) { + return false; + } + return true; + }); @ivababukova https://github.com/ivababukova this error doesn't appear anymore after merging in your in the UI refactor, so I'm removing this. The test works in local. I'm testing it in staging. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/APTCL62SWZW4W3JQBHWHAULUBGTUHANCNFSM5CMKMZNQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

removed

@aerlaut aerlaut merged commit 06b2a0b into master Sep 10, 2021
@aerlaut aerlaut deleted the test-launch-analysis branch September 10, 2021 07:20
alexvpickering pushed a commit that referenced this pull request Mar 14, 2023
Allow for variability in the amoiunt of clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants