Add weekday to time contidion editor #6786

Misiu · 2020-09-04T13:12:04Z

Breaking change

Proposed change

This is the first step to add weekdays support to time condition.
Next will be ha-expand-panel (#6726) that will allow us to hide (collapse) parts that aren't filled

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New feature (thank you!)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example configuration

Additional information

This PR fixes or closes issue: fixes Automations condition.weekday missing in Automation GUI #3833
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
There is no commented out code in this PR.
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

@ludeeus

* Add person badge * Update src/components/user/ha-person-badge.ts Co-authored-by: Joakim Sørensen <[email protected]> * Revert screwup by @ludeeus Co-authored-by: Joakim Sørensen <[email protected]> Co-authored-by: Ludeeus <[email protected]>

src/panels/config/automation/condition/types/ha-automation-condition-time.ts

Co-authored-by: Zack Arnett <[email protected]>

src/panels/config/automation/condition/types/ha-automation-condition-time.ts

Co-authored-by: Zack Arnett <[email protected]>

src/panels/config/automation/condition/types/ha-automation-condition-time.ts

…ant#6719) Co-authored-by: Bram Kragten <[email protected]>

…#6776)

Co-authored-by: Bram Kragten <[email protected]>

Co-authored-by: Joakim Sørensen <[email protected]>

zsarnett · 2020-09-07T18:43:25Z

Needs to be rebased

src/panels/config/automation/condition/types/ha-automation-condition-time.ts

Fix More info content from having space on right

Co-authored-by: Zack Barett <[email protected]>

This reverts commit 48ec0b6.

…nto weekday" This reverts commit de5cab3, reversing changes made to abdb4d9.

This reverts commit abdb4d9.

Misiu · 2020-09-08T09:17:30Z

Replaced by #6848

add weekday to time contidion

182fcec

homeassistant added the cla-signed label Sep 4, 2020

bramkragten and others added 2 commits September 4, 2020 15:18

Fix gauge editor (home-assistant#6783)

faee2c3

Add person badge (home-assistant#6785)

d1a9cb4

* Add person badge * Update src/components/user/ha-person-badge.ts Co-authored-by: Joakim Sørensen <[email protected]> * Revert screwup by @ludeeus Co-authored-by: Joakim Sørensen <[email protected]> Co-authored-by: Ludeeus <[email protected]>

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

remove quote

f7eb824

Co-authored-by: Zack Arnett <[email protected]>

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Show resolved Hide resolved

review fixes part1

a60d3ce

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

code readability

93ed135

Co-authored-by: Zack Arnett <[email protected]>

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

Misiu and others added 3 commits September 4, 2020 16:19

review fixes part2

af0fe76

Minor EN text improvements / fixes (home-assistant#6788)

9c4fdaa

review fixes part3

f1bc311

zsarnett reviewed Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

Misiu commented Sep 4, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Show resolved Hide resolved

review fixes part4

c1847b3

Misiu mentioned this pull request Sep 4, 2020

New component: ha-expansion-panel #6789

Merged

9 tasks

bramkragten and others added 8 commits September 4, 2020 18:30

Tweak card create dialog a bit (home-assistant#6787)

793b9f2

Add basic nodes list & node metadata to OZW config panel (home-assist…

aa5e20d

…ant#6719) Co-authored-by: Bram Kragten <[email protected]>

More Info History: Scrollbar Style (home-assistant#6790)

349a5f5

Allow local storage decorator to register as property (home-assistant…

b065f00

…#6776)

Media Browser Panel (home-assistant#6772)

e63a78b

Co-authored-by: Bram Kragten <[email protected]>

Bumped version to 20200904.0

2adeb88

Add node details shortcut to OZW device pages (home-assistant#6791)

fcc22ba

Co-authored-by: Bram Kragten <[email protected]>

[ci skip] Translation update

d5794c3

bramkragten and others added 5 commits September 7, 2020 19:48

Fix onboarding styling (home-assistant#6819)

80224e6

Automation editor tweaks (home-assistant#6713)

de7ffb1

Co-authored-by: Joakim Sørensen <[email protected]>

Updates to correct zindexs on new dialogs (home-assistant#6816)

5339fe6

Handle media browser errors (home-assistant#6813)

046f7b5

Co-authored-by: Joakim Sørensen <[email protected]>

Bumped version to 20200907.0

f15fbe5

zsarnett reviewed Sep 7, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

zsarnett reviewed Sep 7, 2020

View reviewed changes

src/panels/config/automation/condition/types/ha-automation-condition-time.ts Outdated Show resolved Hide resolved

homeassistant and others added 18 commits September 8, 2020 00:32

[ci skip] Translation update

0889f42

fix more info content

30c47a6

Merge pull request home-assistant#6835 from home-assistant/fix-more-info

01a4d57

Fix More info content from having space on right

Fix header on media browser in safari (home-assistant#6838)

8b1801f

Fix Calendar Card in Add Card dialog (home-assistant#6833)

d7448ec

simplify

327f6ba

Co-authored-by: Zack Barett <[email protected]>

add weekday to time contidion

9349f34

review fixes part1

313a764

review fixes part2

dea7734

review fixes part3

b26062e

review fixes part4

77d2ec9

simplify

112b72f

Co-authored-by: Zack Barett <[email protected]>

rebase + comments

abdb4d9

Merge branch 'weekday' of https://github.com/Misiu/frontend into weekday

de5cab3

remove duplicate interface

48ec0b6

Revert "remove duplicate interface"

3d4358c

This reverts commit 48ec0b6.

Revert "Merge branch 'weekday' of https://github.com/Misiu/frontend i…

72ca9c9

…nto weekday" This reverts commit de5cab3, reversing changes made to abdb4d9.

Revert "rebase + comments"

6960c25

This reverts commit abdb4d9.

Misiu mentioned this pull request Sep 8, 2020

Add weekday to time contidion editor #6848

Merged

9 tasks

Misiu closed this Sep 8, 2020

github-actions bot locked and limited conversation to collaborators Jul 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add weekday to time contidion editor #6786

Add weekday to time contidion editor #6786

Misiu commented Sep 4, 2020

zsarnett commented Sep 7, 2020

Misiu commented Sep 8, 2020

Add weekday to time contidion editor #6786

Add weekday to time contidion editor #6786

Conversation

Misiu commented Sep 4, 2020

Breaking change

Proposed change

Type of change

Example configuration

Additional information

Checklist

zsarnett commented Sep 7, 2020

Misiu commented Sep 8, 2020