Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "experimental" status of TI coordinators from ZHA docs #17089

Merged
merged 4 commits into from
May 9, 2021
Merged

Remove "experimental" status of TI coordinators from ZHA docs #17089

merged 4 commits into from
May 9, 2021

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Mar 21, 2021

Proposed change

ZHA with TI coordinators is relatively stable at this point so I suggest removing the "experimental" warning. There are also no version restrictions anymore with zigpy-znp.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Mar 21, 2021
@Hedda
Copy link
Contributor

Hedda commented Mar 23, 2021

@puddly Suggest also change "CC2531" to "CC253x" since compatible with not only CC2531 but also CC2530 and CC2538 as well:

Radio Type Zigbee Radio Hardware
znp Texas Instruments (e.g., CC253x, CC26x2, CC13x2, zzh!, Slaesh's coordinator)

CC253x also match the format used to list CC26x2 and CC13x2 where the 'x' is used to represent multiple varients of those models:

https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/README.md

PS: There are today even more/newer open-source hardware USB-sticks/dongles and GPIO board available from the community:

https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/bin/README.md

Hedda added a commit to Hedda/zigpy that referenced this pull request Mar 23, 2021
@Hedda
Change zigpy-cc to "legacy" and also list CC253x under zigpy-znp
7219dd4 
Change zigpy-cc to be listed as "legacy" and also list CC253x devices under zigpy-znp as @puddly posted in home-assistant/home-assistant.io#17089 that all Texas Instruments Zugbee coordinators with any Z-Stack version are now relatively stable with zigpy-znp so should no longer be any no need to list versions.
@Hedda Hedda mentioned this pull request Mar 23, 2021
Closed
@frenck frenck marked this pull request as draft March 23, 2021 10:57
@frenck
Copy link
Member

frenck commented Mar 23, 2021

Let's wait for upstream to decide if this is correct or not. Generally, I think this decision should be up to the maintainers.

@Hedda
Copy link
Contributor

Hedda commented Mar 23, 2021

FYI please note that @puddly is today one of the core developers of upstream zigpy and zigpy-znp

@frenck
Copy link
Member

frenck commented Mar 23, 2021

Yes, but the upstream PR is open and not merged.

This was referenced Mar 31, 2021
Merged
Merged
Hedda added a commit to Hedda/zigpy-deconz that referenced this pull request Apr 13, 2021
@Hedda
Add list of compatible hardware to zigpy-deconz README.md
a00a5b6 
Add a list of compatible hardware to zigpy-deconz README.md as the plan is to remove such a list from zigpy in zigpy/zigpy#705

Downstream project(s) also want such information to be provided by upstream as per home-assistant/home-assistant.io#17089
@Hedda Hedda mentioned this pull request Apr 13, 2021
Closed
Hedda added a commit to Hedda/zigpy-xbee that referenced this pull request Apr 13, 2021
@Hedda
Update compatible hardware in zigpy-xbee
9a97d8c 
Update list of compatible hardware to zigpy-xbee README.md as the plan is to remove such a list from zigpy in zigpy/zigpy#705

Downstream project(s) also want such information to be provided by upstream as per home-assistant/home-assistant.io#17089
This was referenced Apr 13, 2021
Merged
Closed
Adminiuga pushed a commit to zigpy/zigpy-xbee that referenced this pull request Apr 15, 2021
@Hedda
Update compatible hardware in zigpy-xbee (#118)
93fe805 
Update list of compatible hardware to zigpy-xbee README.md as the plan is to remove such a list from zigpy in zigpy/zigpy#705

Downstream project(s) also want such information to be provided by upstream as per home-assistant/home-assistant.io#17089
@Hedda
Copy link
Contributor

Hedda commented Apr 26, 2021 •
edited
Loading

Yes, but the upstream PR is open and not merged.

@puddly Bump now that relative zigpy/zigpy#705 and zigpy/zigpy-znp#69 been merged by upstream zigpy/zigpy-znp respectively.

@puddly puddly marked this pull request as ready for review April 30, 2021 04:12
frenck
frenck approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @puddly 👍

../Frenck 🚂

@frenck frenck merged commit 41bd5d4 into home-assistant:current May 9, 2021
@Hedda Hedda mentioned this pull request May 10, 2021
Merged
8 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@puddly @Hedda @frenck @homeassistant