🐛 Enables landline phones in HdPhoneInput #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚮 The files previously deployed on /homeday-blocks/1247/ were already removed. |
|
🎉 This PR is included in version 19.17.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if anyone remembers the day we had an issue with the landline phone numbers on the website:
https://homeday.slack.com/archives/C01S70CGKA8/p1670250340393059
This was being deemed invalid by the input and blocking some requests.
So, there are plans now of using this input in sliders, so we need to make sure it works for landlines too.
I added a new boolean prop allow or not only mobile phones.
I also fixed the error for duplicated keys that the component had and removed some unnecessary prop binding in the html (which resulted in new snapshots).