Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stream support and fix some bugs #28

Merged
merged 2 commits into from
Mar 31, 2023
Merged

feat: add stream support and fix some bugs #28

merged 2 commits into from
Mar 31, 2023

Conversation

tangye1234
Copy link
Contributor

@tangye1234 tangye1234 commented Mar 31, 2023 •
edited
Loading

Currently, c.body(stream) is not very friendly to stream support.

  • Stream transfer;
  • Potential crashes;
  • Unable to cancel stream flow upon user abort request.

Modify tsconfig es target to 2022 to support Error cause

  • Only Error types are accepted by outgoing.destroy, but the thrown exception may not be an Error. Use es2022 cause to solve.

hono throws a TimeoutError exception and returns a 504 instead of a 500 error.

@tangye1234 tangye1234 mentioned this pull request Mar 31, 2023
Closed
yusukebe
yusukebe reviewed Mar 31, 2023
View reviewed changes
@yusukebe
Copy link
Member

Hi @tangye1234 !

Looks good! One thing. I've noticed there is a typo.

@tangye1234
Copy link
Contributor Author

Hi @tangye1234 !

Looks good! One thing. I've noticed there is a typo.

Sure

@yusukebe
Copy link
Member

Thanks!

@yusukebe yusukebe merged commit b0c4161 into honojs:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusukebe yusukebe yusukebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tangye1234 @yusukebe