Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show actual assert count next to expected count #561

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

matteeyah
Copy link
Contributor

Summary

When assert against a specific count of turbo streams, the error message can be confusing. When you assert 2 streams, but there is only one, the error message says there's no streams - (Expected 2 Turbo Stream broadcasts on "Z2lkOi8vb3B0b25hbC9SZWNvcmRpbmcvMjcyMzgxNjI3:analysis", but there were none). This is confusing, because it implies that here were no streams, but in fact, it reports this error message when the expected count is not the same as the asserted count.

Proposal

Show the actual count next to the expected count when asserting against a specific count.

@matteeyah
Copy link
Contributor Author

@afcapel Can you take a look at this simple change, please?

@afcapel afcapel merged commit 5d2b127 into hotwired:main Jan 29, 2024
15 checks passed
@afcapel
Copy link
Contributor

afcapel commented Jan 29, 2024

Thanks @matteeyah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants