Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include Turbo::Broadcastable::TestHelper with Action Cable #574

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Only include Turbo::Broadcastable::TestHelper with Action Cable #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/turbo/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,14 @@ class Engine < Rails::Engine
initializer "turbo.test_assertions" do
ActiveSupport.on_load(:active_support_test_case) do
require "turbo/test_assertions"
require "turbo/broadcastable/test_helper"

include Turbo::TestAssertions
include Turbo::Broadcastable::TestHelper
end

ActiveSupport.on_load(:action_cable) do
ActiveSupport.on_load(:active_support_test_case) do
require "turbo/broadcastable/test_helper"
include Turbo::Broadcastable::TestHelper
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanpdoyle what do you think about adding a ActiveSupport.on_load(:action_cable) block here? The Rails guides suggest this technique to execute code that depends on several dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea. I was unsure about nesting, but I'll try it out.

end

ActiveSupport.on_load(:action_dispatch_integration_test) do
Expand Down