Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoparallel] fixed wrong generated strategy for dot op #1746

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

FrankLeeeee
Copy link
Contributor

@FrankLeeeee FrankLeeeee commented Oct 20, 2022

What is the problem?

The previous node handler lacks one correctness check which is to check whether the sharding spec's entire_shape attribute is the actual physical tensor shape.

What does this PR do?

This PR mainly does 3 things.

  1. I added the shape check in the node handler to make sure the results of post-process is correct. Such stricter checks will help us identify some potential bugs in our implementation.
  2. Thanks to the first point, I found that there are some bugs in the linear strategy generator and node handler. Thus, I fixed the broken unit testing.
  3. Some other broken unit tests are skipped temporarily and I will fix them in a separate PR.

@FrankLeeeee FrankLeeeee merged commit 8b8937d into hpcaitech:main Oct 20, 2022
@FrankLeeeee FrankLeeeee deleted the hotfix/dot-handler branch January 26, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants