-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fx] skip diffusers unitest if it is not installed #1799
Conversation
Should we remove diffusers from test_requirements.txt also? The CI has difficulties installing this. |
The standard operation procedure is that, when a developer wants to the do the test, he/she should do |
Sorry accidentally clicked on the |
Let's set dependencies such as torchrec, diffuser, and triton as optional in the CAI unit test. In my opinion, our unit tests do not need to be coupled with them.
|
OK, this is fine. I can create another decorator to handle this case. Otherwise, every unit test file depending on these libraries will have redundant code
|
why use else instead of except? |
No description provided.