Disabled broken scaling feature on Linux Qt environments #128
Conversation
| @@ -84,8 +84,11 @@ Q_DECL_EXPORT int main(int argc, char *argv[]) | |||
| res.transpose(); | |||
| pixel_xres = res.width(); | |||
| pixel_yres = res.height(); | |||
|
|
|||
| #ifdef Q_WS_X11 | |||
There was a problem hiding this comment.
@xsacha is this define safe?
-[Unknown]
There was a problem hiding this comment.
Q_WS_X11 will be defined for Meego, Raspberry Pi, Pandora, ... as well. Is that the intention?
I usually use #if defined(Q_WS_X11) && !defined(ARM) to avoid mobile platforms. See below.
Looks like you might want it on Raspberry Pi though -- since it acts like a normal desktop.
There was a problem hiding this comment.
It is also possible for a normal linux desktop to be running with an ARM CPU. I think the quickest way to avoid those platforms is to explicitly check for them. Though ugly I cant think of some 'normal desktop pc' flag. Editing.
|
@unknownbrackets I think that should make it considerably safer. It avoids all supported mobile platforms without excluding any desktops. I would have liked something more comprehensive but there is not any kind of ifdef for portable devices in general unfortunately. I can confirm it fixes hrydgard/ppsspp#3710 |
Disabled broken scaling feature on Linux Qt environments
| @@ -17,6 +17,10 @@ | |||
| #endif | |||
| #include "QtMain.h" | |||
|
|
|||
| #if defined(Q_WS_X11) && !defined(MEEGO_EDITION_HARMATTAN) && !defined(__SYMBIAN32__) && !defined(BLACKBERRY) | |||
There was a problem hiding this comment.
Out of those, only Meego uses X11.
No description provided.