PPSSPP:- Read Framebuffers to Memory (CPU) option is broken since v0.9.8-777 for all games. (OpenGL 3.x and below, Windows)

[solarmystic]

(Edited to reflect proper first responsible commit)

Issue is as stated in the title. First responsible commit is 6854885 (v0.9.8-777) by @raven02 which was part of the #6049 pull request recently merged to master.

Last unaffected build is v0.9.8-776 cf7229e

Issue reproduction:-

1. Load up any game which requires Read Framebuffers to Memory for proper functionality like Ys Seven (minimap) or Danganronpa (door and object scanning) or Trails in the Sky (status menu transparency) using any build from v0.9.8-777 onwards. The buildbot is broken, so self-compiling is necessary for the reproduction.
2. Ensure that the rendering mode is set to Read Framebuffers to Memory beforehand.
3. The change in rendering mode fails to produce the desired results in the selected game. In Danganronpa, that means that door and object scanning is broken. In Ys Seven, the minimap fails to display correctly.

System used for testing:-

Note:-

Will most likely affect users with cards that only support up to Open GL 3.x. Users with OpenGL 4.x cards and above will not be affected by this issue.

[solarmystic]

Urgh, I got mislead by a red herring during the bisecting. The actual first responsible commit is 6854885 also by @raven02

It turns out that it was the GLES3 lines causing the issue after all. Edited the issue report to reflect that.

[solarmystic]

Okay, so commenting out the GLES3 line for 6854885 at lines 1277 and 1280 in Framebuffer.cpp resolved the issue for me. No other side effects too, afaict.

That could be resolution to this issue. The MAY_HAVE_GLES3 line is already sufficient to properly limit the function to the appropriate cards. One could just open a pull request to remove those lines, I don't think they're supposed to be there after all.

[dbz400]

Yep , i done it in framebuffer-clut branch .Probably need to do one here?

[solarmystic]

@raven02 Yes, please. Do open the pull request, it should be a simple fix. Thanks in advance.

[solarmystic]

Nevermind that, it's fixed by #6140. Thanks @unknownbrackets !

Closed.

[solarmystic]

@unknownbrackets
Looks like i spoke to soon, with regards to #6137 being completely fixed for OpenGL 3.x and below.

Danganronpa is fixed for Read Framebuffers to Memory (CPU) [RFB2M] mode functionality wise but a few other games like Ys Seven fail to work properly in the aforementioned mode.

Ys Seven (minimap fails to display properly in RFB2M mode)

Additionally, there is a strange new bug introduced in Danganronpa, the background screen is flipped upside down in the load screen dialogue and other places:-

Ys Seven (backround of the big map is also flipped upside down)

In Trails in the Sky, entering the status menu flips the transparent background upside down too:-

Tests were done with Simulate Block Transfer option disabled and Read Framebuffers to Mem (CPU) enabled.

Reopening.

[solarmystic]

Additional bugs resolved by #6141.

Closed, will reopen if new ones arise.