refactor: use Signal::get_untracked() in non reactive contexts

[hrzlgnm]

Also deduplicate the service_type input empty condition while deriving the signal.

Summary by Sourcery

Use Signal::get_untracked() in non-reactive contexts to avoid unnecessary re-renders.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request replaces the usage of the reactive get() method with the non-reactive get_untracked() method on RwSignal in contexts where reactivity is not required. This change prevents unnecessary re-renders and side effects, improving performance. The changes were made in the Browse function and in the App function when initializing and updating the theme.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Replaced reactive get() calls with non-reactive get_untracked() calls in several places to prevent unnecessary re-renders or side effects in non-reactive contexts.	Replaced browsing.get() with browsing.get_untracked() in the Browse function. Replaced service_type.get() with service_type.get_untracked() in the Browse function. Replaced brand_colors.get() with brand_colors.get_untracked() when initializing the theme. Replaced brand_colors.get() with brand_colors.get_untracked() when setting the dark theme. Replaced brand_colors.get() with brand_colors.get_untracked() when setting the light theme.	src/app.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @hrzlgnm - I've reviewed your changes - here's some feedback:

Overall Comments:

• It looks like you're consistently using get_untracked in these contexts, which is good for performance. Consider adding a comment explaining why get_untracked is necessary in these specific cases to improve readability.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}