Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancelation in http and ws clients #875

Merged
merged 4 commits into from
May 27, 2023
Merged

Conversation

armanbilge
Copy link
Member

h/t @hnaderi for reporting in #874 (comment).

tl;dr we were making the requests uncancelable by mistake 🙃

Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@amesgen amesgen merged commit b23cb63 into series/0.9 May 27, 2023
@amesgen amesgen deleted the pr/fix-cancelation branch May 27, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants