-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for scala 3 - series/0.23 #55
Conversation
@@ -1,2 +1,2 @@ | |||
addSbtPlugin("org.http4s" % "sbt-http4s-org" % "0.14.9") | |||
addSbtPlugin("com.typesafe.sbt" % "sbt-twirl" % "1.5.1") | |||
addSbtPlugin("com.typesafe.play" % "sbt-twirl" % "1.6.0-M7") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this transitively add a jar dependency? With the change in release coordinates, I think this would be a breaking change.
What we could do -- and have done in these integration modules -- is create an 0.24 release against http4s-0.23 core. Then Twirl can stay current without forcing a breaking change to everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this wasn't a problem on #54, because there's no bincompat yet on the 1.x liine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Will do tomorrow. Thanks for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossabaker I couldn't find an example of the ritual of bumping minor version in regards to mima.
Do we set mimaPreviousArtifacts
to Set.empty
in this PR and immediately remove the setting after a 0.24.0-M1
release or is there way to let mima automatically skip checking for the first 0.24.x
release?
|
7ac4b77
to
4117a37
Compare
that worked. thanks! |
Alright, if you create |
And I probably wouldn't bother to maintain 0.23 anymore at that point, unless there's a security thing. |
Done, if you approve, I can merge and tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good.
same as #54