Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for scala 3 - series/0.23 #55

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

kailuowang
Copy link
Contributor

same as #54

@@ -1,2 +1,2 @@
addSbtPlugin("org.http4s" % "sbt-http4s-org" % "0.14.9")
addSbtPlugin("com.typesafe.sbt" % "sbt-twirl" % "1.5.1")
addSbtPlugin("com.typesafe.play" % "sbt-twirl" % "1.6.0-M7")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this transitively add a jar dependency? With the change in release coordinates, I think this would be a breaking change.

What we could do -- and have done in these integration modules -- is create an 0.24 release against http4s-0.23 core. Then Twirl can stay current without forcing a breaking change to everything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this wasn't a problem on #54, because there's no bincompat yet on the 1.x liine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Will do tomorrow. Thanks for the review.

Copy link
Contributor Author

@kailuowang kailuowang Dec 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossabaker I couldn't find an example of the ritual of bumping minor version in regards to mima.
Do we set mimaPreviousArtifacts to Set.empty in this PR and immediately remove the setting after a 0.24.0-M1 release or is there way to let mima automatically skip checking for the first 0.24.x release?

@rossabaker
Copy link
Member

tlMimaPreviousArtifacts should default to doing the right thing when we bump tlBaseVersion. I would bump that to 0.24 and remove the tlMimaPreviousArtifacts entirely and see where that gets us.

@kailuowang
Copy link
Contributor Author

tlMimaPreviousArtifacts should default to doing the right thing when we bump tlBaseVersion. I would bump that to 0.24 and remove the tlMimaPreviousArtifacts entirely and see where that gets us.

that worked. thanks!

@rossabaker
Copy link
Member

Alright, if you create series/0.24 off series/0.23 and retarget this into that, it should be all set. And then it can be tagged 0.24.0-M1 to match the Twirl milestone status.

@rossabaker
Copy link
Member

And I probably wouldn't bother to maintain 0.23 anymore at that point, unless there's a security thing.

@kailuowang kailuowang changed the base branch from series/0.23 to series/0.24 December 13, 2022 19:10
@kailuowang
Copy link
Contributor Author

Done, if you approve, I can merge and tag.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@kailuowang kailuowang merged commit 182e418 into http4s:series/0.24 Dec 13, 2022
@kailuowang kailuowang deleted the scala3_0.23 branch December 13, 2022 20:57
@kailuowang kailuowang mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants