Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ignoring binaryPath if binary doesn't end in version #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuyuribr
Copy link

@tuyuribr tuyuribr commented Jan 7, 2024

When setting a option like <option name="binaryPath" value="C:\bins\llm-ls" /> it would be ignored.
Currently the llm-ls release for windows only returns 2 files:

llm-ls.exe
llm_ls.pdb

inducing user error of setting the path directly to %randomPath%/llm-ls.exe and failing the if check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants