Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] add the missing .eval() for inference #2408

Merged
merged 8 commits into from
Mar 7, 2025

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Mar 5, 2025

No description provided.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending the tests and making them XPU compatible. I found one small issue, the rest looks good.

Regarding the testing, did you run the bnb regression tests and the LoftQ tests successfully on XPU?

@faaany
Copy link
Contributor Author

faaany commented Mar 6, 2025

Thanks for extending the tests and making them XPU compatible. I found one small issue, the rest looks good.

Regarding the testing, did you run the bnb regression tests and the LoftQ tests successfully on XPU?

No, not all bnb and LoftQ tests pass. We only focus on cases that pass on CUDA but fail on XPU. If they fail on CUDA, we are not trying to fix them now.

@faaany faaany marked this pull request as ready for review March 6, 2025 02:10
@BenjaminBossan
Copy link
Member

No, not all bnb and LoftQ tests pass. We only focus on cases that pass on CUDA but fail on XPU. If they fail on CUDA, we are not trying to fix them now.

Could you please share which CUDA tests are failing? Normally, that shouldn't happen.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member

@faaany I merged your other PR. I think this one has some overlap with it, could you please rebase on/merge with the latest main branch? Then I'll do a final review.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the missing .eval() calls to the tests.

@BenjaminBossan BenjaminBossan merged commit 8edaae9 into huggingface:main Mar 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants