-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] add the missing .eval()
for inference
#2408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for extending the tests and making them XPU compatible. I found one small issue, the rest looks good.
Regarding the testing, did you run the bnb regression tests and the LoftQ tests successfully on XPU?
No, not all bnb and LoftQ tests pass. We only focus on cases that pass on CUDA but fail on XPU. If they fail on CUDA, we are not trying to fix them now. |
Could you please share which CUDA tests are failing? Normally, that shouldn't happen. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@faaany I merged your other PR. I think this one has some overlap with it, could you please rebase on/merge with the latest main branch? Then I'll do a final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the missing .eval()
calls to the tests.
No description provided.