Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flex_attn to diffllama #35601

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add flex_attn to diffllama #35601

merged 1 commit into from
Jan 9, 2025

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

Should solve failing consistency checks

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ArthurZucker
Copy link
Collaborator

(Modeling file is not changed)

@ArthurZucker ArthurZucker merged commit 8de7b1b into main Jan 9, 2025
17 checks passed
@ArthurZucker ArthurZucker deleted the muellerzr-fix-failing-diffq branch January 9, 2025 19:49
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Cyrilvallez
Copy link
Member

Actually I don't think DiffLlama supports flex, does it? 🤔 It's still in the old format with classes

@ArthurZucker
Copy link
Collaborator

mmmm yeah looks like it but the pretrained mode in modular is a bit wrong in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants