Add cluster and nodes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate to a a different uuid library the old one is stale (satori/go.uuid#84).
anagrius
reviewed
Nov 6, 2019
cmd/nodes.go
Outdated
| func newNodesCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "nodes", | ||
| Short: "Manage nodes", |
There was a problem hiding this comment.
Maybe you should make the distinction between nodes and cluster commands clear.
I was confused at first since in my mind "nodes" is part of cluster management.
The least you could do would maybe be include a bit more description in the "Short" field for both. Alternatively nest the nodes command under cluster
There was a problem hiding this comment.
Good point. I think I'll move nodes to a nested command under cluster.
anagrius
approved these changes
Nov 6, 2019
…ences with cluster in the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added a separate commit to clean up a few things, including moving to a new
uuidpackage.This is the first time I'm touching this repo, so let me know if you need me to change anything. The main thing I needed was to extend the API with the new types/queries/mutations, and to a lesser extent expanding on the CLI tool itself. I'm sure the output of the CLI tool could be adjusted, but not 100% certain exactly what data to present to the user, especially since we don't yet support JSON formatted output.