Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/view actions #53

Merged
merged 14 commits into from
Nov 5, 2020
Merged

Conversation

mahlunar
Copy link
Contributor

@mahlunar mahlunar commented Nov 5, 2020

Context

This PR relates to the following issue: humio/humio-operator#207 - CRD for HumioViews

The View API needs additional functions before we can add a CRD for managing views. This is the first PR on that journey.

This is my first open source PR so bear with me

Overview of changes

  1. Added the following operations to Views

    • Create
    • Update Connections
    • Update Description
    • Delete
  2. Updated the CLI with the new operations as well.

  3. Fixed a bug in Delete repository which returned an error after successfully deleting a repository due to a graphQL query error.

Copy link
Collaborator

@danielamkaer danielamkaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the commands and found no issues.

mahlunar and others added 3 commits November 5, 2020 12:04
Co-authored-by: Daniel Amkær Sørensen <[email protected]>
Co-authored-by: Daniel Amkær Sørensen <[email protected]>
Co-authored-by: Daniel Amkær Sørensen <[email protected]>
@mahlunar
Copy link
Contributor Author

mahlunar commented Nov 5, 2020

Thanks for the quick reaction. I have committed the suggested changes.

@mahlunar mahlunar requested a review from danielamkaer November 5, 2020 11:09
Copy link
Collaborator

@danielamkaer danielamkaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@danielamkaer danielamkaer merged commit d2b1496 into humio:master Nov 5, 2020
@mahlunar
Copy link
Contributor Author

mahlunar commented Nov 6, 2020

Thanks. 🚀 Quick question. Would it be possible to get a new release of the CLI? We would need it to complete humio/humio-operator#207

@danielamkaer
Copy link
Collaborator

Sure. Version 0.28.1 released. 🎉

@mahlunar mahlunar deleted the feature/View-Actions branch November 6, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants