-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/view actions #53
Conversation
…er sucessfully deleteting a repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested the commands and found no issues.
Co-authored-by: Daniel Amkær Sørensen <[email protected]>
Co-authored-by: Daniel Amkær Sørensen <[email protected]>
Co-authored-by: Daniel Amkær Sørensen <[email protected]>
Thanks for the quick reaction. I have committed the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks!
Thanks. 🚀 Quick question. Would it be possible to get a new release of the CLI? We would need it to complete humio/humio-operator#207 |
Sure. Version 0.28.1 released. 🎉 |
Context
This PR relates to the following issue: humio/humio-operator#207 - CRD for HumioViews
The View API needs additional functions before we can add a CRD for managing views. This is the first PR on that journey.
This is my first open source PR so bear with me
Overview of changes
Added the following operations to Views
Updated the CLI with the new operations as well.
Fixed a bug in Delete repository which returned an error after successfully deleting a repository due to a graphQL query error.