Publish docker image #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schofield
approved these changes
Jun 11, 2019
mwl
reviewed
Jun 12, 2019
| @@ -0,0 +1,5 @@ | |||
| FROM scratch | |||
|
|
|||
| COPY humioctl /humioctl | |||
There was a problem hiding this comment.
With Docker multistage builds you don't have to build humioctl prior to building the docker image. And you can have Docker Hub do it all for you :)
There was a problem hiding this comment.
In this case we're shipping binaries to other places such as homebrew, so we have to build the binaries anyway. I've never used goreleaser but apparently it's able to figure out the docker image depends on the binary so it works out the order of operations. I agree though typically the build of the binary should be done in docker... Maybe we will move that way if it becomes hard to do this with drone (haven't gotten that far yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.